PORTS--Cloudy #40
Open
PORTS--Cloudy #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed actions to the works controller
Media RankerWhat We're Looking For
Cloudy, let's meet and talk about what happened with this project; your TaskList project was farther along than this. You and I have spoke about speed before, but I want to look back on this project and talk about:
As always; the code you have is good. You got the beginnings of the WorksController correct. But I want to understand how this project got to the state that it's in, and what you need to change in order to push forward. |
tildeee
reviewed
May 3, 2019
|
|
||
| <p>Creator: <%= @work.creator%> </p> | ||
|
|
||
| <div> |
There was a problem hiding this comment.
The content inside of this div should be indented
tildeee
reviewed
May 3, 2019
config/routes.rb
Outdated
| @@ -0,0 +1,10 @@ | |||
| Rails.application.routes.draw do | |||
| get 'works/index' | |||
tildeee
reviewed
May 3, 2019
config/routes.rb
Outdated
| root to: "works#index" | ||
| # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html | ||
| # root to: 'works#path' | ||
| resources :works |
tildeee
reviewed
May 3, 2019
app/views/works/index.html.erb
Outdated
| @@ -0,0 +1,23 @@ | |||
| <h1>Works#index</h1> | |||
| <p>Find me in app/views/works/index.html.erb</p> | |||
There was a problem hiding this comment.
I'd expect at least this h1 and this p to be deleted at some point...
…ser and vote. updated routes. added some tests in users and works and added actsas gem to gem file.
…ed the index and show works.
…to account for votes and users show, fleshed out the acts as votable implementation to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?